On Di, 08 Aug 2023, Yegappan Lakshmanan wrote:
> On Tue, Aug 8, 2023 at 12:57 PM Christian Brabandt <[email protected]> wrote: > > On Di, 08 Aug 2023, Christian Brabandt wrote: > > > > > patch 9.0.1679: Cleanup Tests from leftover files > > > > Sorry, trying to get the patch mails working. > > > > While this seems to fix the recent CI test failures about the file > > Xcrypt_sodium_v2.txt now I am seeing sodium_mlock() failures. I don't > > know yet why this happens :( > > > > The git log commit message for this patch has a lot of details. Bram > used to mention > a short description of the problem and the solution in the commit log. > Should we follow > that model going forward? I certainly don't want to make any rules here. I liked the way how Bram was able to make short Problem and Solution Descriptions, but at least personally I think the Vim project can benefit from better commit messages that go into a bit more detail trying to explain the reasoning for why certain changes were made. I like how the git project does it. But that is only my personal preference. Best, Christian -- Wer ist's, der Kohl vom Hocker lockt, auf dem er nur noch locker hockt? -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/ZNNQpIz7Iyha9%2BiT%40256bit.org.
