I tried contacting the author, but got their email address wrong, so I'll
just copy my message here. Would you accept this patch, or do you want a PR?




I looked at your PR, and since things are still 'in flux', I thought
I'd share this off-list, beacuse I would like to add to your PR, and
that doesn't work well at the moment :-)

Here's my diff:

diff --git a/src/testdir/dumps/Test_incsearch_restore_view_02.dump
b/src/testdir/dumps/Test_incsearch_restore_view_02.dump
index 2a2c9a2b8..c17163947 100644
--- a/src/testdir/dumps/Test_incsearch_restore_view_02.dump
+++ b/src/testdir/dumps/Test_incsearch_restore_view_02.dump
@@ -2,5 +2,5 @@
 @20
 @20
 @20
-|x+1&&@2| +0&&@16
-|/|x@2> @15
+|x+1&&@1|x+0&&| @16
+|/|x@1> @16
diff --git a/src/testdir/test_search.vim b/src/testdir/test_search.vim
index f3bc6bff7..1a9f49bfe 100644
--- a/src/testdir/test_search.vim
+++ b/src/testdir/test_search.vim
@@ -2094,8 +2094,10 @@ func Test_incsearch_restore_view()
   let buf = RunVimInTerminal('-S Xincsearch_restore_view', {'rows':
6, 'cols': 20})

   call VerifyScreenDump(buf, 'Test_incsearch_restore_view_01', {})
- call term_sendkeys(buf, '/xxx')
+ call term_sendkeys(buf, '/xx')
   call VerifyScreenDump(buf, 'Test_incsearch_restore_view_02', {})
+ call term_sendkeys(buf, 'x')
+ call VerifyScreenDump(buf, 'Test_incsearch_restore_view_03', {})
   call term_sendkeys(buf, "\<Esc>")
   call VerifyScreenDump(buf, 'Test_incsearch_restore_view_01', {})




Here's the new Screendump file. It checks a jumping viewport I noticed
after typing 2 xx after the /:
$ cat dumps/Test_incsearch_restore_view_03.dump
| +0&#ffffff0@19
@20
@20
@20
|x+1&&@2| +0&&@16
|/|x@2> @15

(this is basically the old ...02.dump, because I shifted them one up...)

Does this make sense?


Christ van Willegen

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/CA%2BOt1OwKC4kX1ySGvU-%3D_Q69TnXo0pRx1%3DbYhL0y461JqhhXQQ%40mail.gmail.com.

Raspunde prin e-mail lui