On 12-Feb-2024 02:32, Christian Brabandt (Vim Github Repository) wrote:

can you make a PR for this please?

—
Reply to this email directly, view it on GitHub <https://github.com/vim/vim/issues/14002#issuecomment-1937786687>. You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/14002/1937786...@github.com>

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---
You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/vim/vim/issues/14002/1937786687%40github.com <https://groups.google.com/d/msgid/vim_dev/vim/vim/issues/14002/1937786687%40github.com?utm_medium=email&utm_source=footer>.
Hi Christian,

I have made my first PR (#14029).

When I did so, I got a 9 failing checks which mostly appear to be failing tests, like this:
<snip>
command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[642]..function RunTheTest[57]..Test_prop_below_split_line[25]..StopVimInTerminal[17]..WaitForAssert[2]..<SNR>4_WaitForCommon[11]..<lambda>38 line 1: Expected 'finished' but got 'running'
Flaky test failed too often, giving up
</snip>

I'm not sure how to proceed with this. This is my first PR.

Any suggestions would be appreciated.

Cheers
John

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/be04c922-1adb-4f1c-a9a2-2642728fddae%40internode.on.net.

Raspunde prin e-mail lui