runtime(netrw): do not double escape Vim special characters
Commit:
https://github.com/vim/vim/commit/2328a39a54fbd75576769193d7ff1ed2769e2ff9
Author: Konfekt <[email protected]>
Date: Fri Dec 20 19:41:02 2024 +0100
runtime(netrw): do not double escape Vim special characters
This double escaping was likely introduced because it was the only way
to make :Open work with hashes/percent signs despite shellescape(..., 1)
supposedly taking care of it, but then breaks the gx mapping
on MSYS2 as reported at [0]
Since special characters in the URL following :Open can be escaped,
whereas gx simply breaks and is more common, no longer double escape
[0]: https://github.com/vim/vim/issues/16252
fixes: #16252
closes: #16265
Signed-off-by: Konfekt <[email protected]>
Signed-off-by: Christian Brabandt <[email protected]>
diff --git a/runtime/autoload/netrw.vim b/runtime/autoload/netrw.vim
index c6af6ca4b..96cfdb600 100644
--- a/runtime/autoload/netrw.vim
+++ b/runtime/autoload/netrw.vim
@@ -5200,8 +5200,7 @@ fun! netrw#BrowseX(fname,remote)
endif
endif
- " although shellescape(..., 1) is used in netrw#Open(), it's insufficient
- call netrw#Open(escape(fname, '#%'))
+ call netrw#Open(fname)
" cleanup: remove temporary file,
" delete current buffer if success with handler,
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/vim_dev/E1tOhzn-00A1rx-Mt%40256bit.org.
