patch 9.2.0395: tests: Test_backupskip() may read from $HOME
Commit:
https://github.com/vim/vim/commit/8d9c383aaff17f5991f739a6d0f06017022b2198
Author: D. Ben Knoble <[email protected]>
Date: Sun Apr 26 08:33:59 2026 +0000
patch 9.2.0395: tests: Test_backupskip() may read from $HOME
Problem: tests: Test_backupskip() may read from $HOME
Solution: Set $HOME to an empty value, use --clean
(D Ben Knoble)
Even though we unset HOME, we can see via scriptnames that user files
are still sourced! One of my installed plugins warns when not compiled
with +python3, so this test has a "press Enter" prompt.
Use `--clean` like most other GetVimProg()'s do to fix it. Some tests
use `system()` instead, but that turns this test into a failure rather
than passing; I'm not sure why other tests don't suffer from this.
To prove to ourselves, we can use code like this:
diff --git i/src/testdir/test_options.vim w/src/testdir/test_options.vim
index a408e20e1..044364a54 100644
--- i/src/testdir/test_options.vim
+++ w/src/testdir/test_options.vim
@@ -1179,6 +1179,7 @@ func Test_backupskip()
" P_NODUP). Run this in a separate instance and write v:errors in a
file,
" so that we see what happens on startup.
let after =<< trim [CODE]
+ call writefile([execute('scriptnames')], 'foo')
let bsklist = split(&backupskip, ',')
call assert_equal(uniq(copy(bsklist)), bsklist)
call writefile(['errors:'] + v:errors, 'Xtestout')
@@ -1196,7 +1197,7 @@ func Test_backupskip()
" unset $HOME, so that it won't try to read init files
let saveenv['HOME'] = getenv("HOME")
call setenv('HOME', v:null)
- exe 'silent !' . cmd
+ exe 'silent !' . cmd .. ' --cmd "echo &rtp"'
call assert_equal(['errors:'], readfile('Xtestout'))
" restore environment variables
Here, that causes "foo" to include a bunch of files under ~/.vim. I'm
not sure why this happens, but lets paper over it for the test.
We can also tell that (orthogonal to --clean) setting HOME='' works too.
Let's do that in addition since unsetting HOME isn't quite enough.
closes: #20051
Signed-off-by: D. Ben Knoble <[email protected]>
Signed-off-by: Christian Brabandt <[email protected]>
diff --git a/src/testdir/test_options.vim b/src/testdir/test_options.vim
index 76a1bff34..b1be22446 100644
--- a/src/testdir/test_options.vim
+++ b/src/testdir/test_options.vim
@@ -1185,7 +1185,7 @@ func Test_backupskip()
qall
[CODE]
call writefile(after, 'Xafter', 'D')
- let cmd = GetVimProg() . ' --not-a-term -S Xafter --cmd "set enc=utf8"'
+ let cmd = GetVimProg() . ' --clean --not-a-term -S Xafter --cmd "set
enc=utf8"'
let saveenv = {}
for var in ['TMPDIR', 'TMP', 'TEMP']
@@ -1193,9 +1193,9 @@ func Test_backupskip()
call setenv(var, '/duplicate/path')
endfor
- " unset $HOME, so that it won't try to read init files
+ " set $HOME='', so that Vim won't try to read init files
let saveenv['HOME'] = getenv("HOME")
- call setenv('HOME', v:null)
+ call setenv('HOME', '')
exe 'silent !' . cmd
call assert_equal(['errors:'], readfile('Xtestout'))
diff --git a/src/version.c b/src/version.c
index 0946dbadc..369938147 100644
--- a/src/version.c
+++ b/src/version.c
@@ -729,6 +729,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 395,
/**/
394,
/**/
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/vim_dev/E1wGv6t-001xQ7-HI%40256bit.org.
