2009/4/25 Kazuki Sakamoto:
>
> Ok, I see. I have fixed patches.
> It will send message from keyDown and performKeyEquivalent when IM
> state is changed.
> What about it?

Thanks, it looks better now.

In the future I'd appreciate it a lot if you made sure there were no
compilation warnings introduced by your patches to save me the time
from having to fix them myself.  As it was I fixed the following
warnings:

option.c: In function ‘set_bool_option’:
option.c:7572: warning: implicit declaration of function ‘im_set_control’

src/MacVim/MMTextViewHelper.m:960: warning: incomplete implementation
of category ‘Private’
src/MacVim/MMTextViewHelper.m:960: warning: method definition for
‘-performImState’ not found

(There isn't much we can do about the "deprecated API warning" since
we need to support 10.4 and there is no straightforward newer API to
use in this case.)

Other than that it looks good -- you've made sure it works with ATSUI
as well which is a bonus. ;)

I did add some comments which state why we moved the IM code to the
frontend (since I'm likely to forget in a couple of months and start
wondering why its not in the backend :).


Thanks again for the patch,
Björn

--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_mac" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---

Reply via email to