Hi! On Sun, 2 Mar 2014 21:30:37 +0100, Daniel Carl <[email protected]> wrote: > Hannes Schüller <[email protected]> wrote: > > since this troubling effect turned up on IRC again, I'd like to try > > and dig a little deeper still. Of course, the issue is still that I > > can't reproduce the behaviour myself. To identify a possible cause, > > I made a small patch (attached). It would be great if anyone who > > experienced the issue of the non-working F in the past could try it > > out. > > I started to inspect the issue on webkitgtk 2.2.5. > [...] > I'm out of ideas how we can fire the click event to open the link > into a new window. Or how we can click the element in a way that the > 'notify_event_cb' is triggered.
Thanks, Daniel, for this detailed test campaign! What could work, in principle, and the reason why I tried this incomplete mini-patch, would be reverting part of the link firing logic to what we used back before you rewrote this part. Not touching the main part, of course, as that all works great. Just the following: Extend _openNewWindow (hinting.js) to determine what kind of hinted element it is. - If there is some onclick event or similar, generate the mouse click as right now. The target attribute would not do anything anyway in this case, so F behaves like f. - If it's a regular link, return "tabopen;URL". The logic to handle this is still in the script function in main.c, so it would work. I acknowledge and appreciate that this would be much less elegant than the current implementation as it relies on specific, positive tests instead of generic, timeless solutions, but if we consider all possible options (hinting modes), it should work. Do you see any issues? Hannes ------------------------------------------------------------------------------ Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk _______________________________________________ Vimprobable-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/vimprobable-users
