On Tue, Mar 12, 2013 at 5:50 AM, Alex Jia <[email protected]> wrote: > On 03/12/2013 03:07 PM, [email protected] wrote: >> >> From: Lei Yang<[email protected]> >> >> Signed-off-by: Lei Yang<[email protected]> >> --- >> crontab/crontab.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/crontab/crontab.py b/crontab/crontab.py >> index 6332109..1462f11 100755 >> --- a/crontab/crontab.py >> +++ b/crontab/crontab.py >> @@ -1,4 +1,4 @@ >> -#!/bin/python >> +#!/usr/bin/python > > > NACK, the location of python can vary widely, so we can't use an absolute > pathname, > a good fix is to replace above line with "/usr/bin/env python", which will > searche $PATH > for python and runs it.
In theory, excellent idea. In practice, inside autotest we have some scripts that use the flag -u, for unbuffered stdout. For virt tests, since we're not too tied to autotest, using /usr/bin/env is fine, so it makes sense to write a patch to change this wholesale. _______________________________________________ Virt-test-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-test-devel
