Re: [virt-tools-list] [virt-manager PATCH] localization: mark several strings as translatable

[Christophe Fergeau]

On Fri, Feb 05, 2016 at 10:40:02AM -0500, Cole Robinson wrote:
> Comments inline
> 
> On 02/05/2016 10:23 AM, Pavel Hrdina wrote:
> > @@ -628,8 +628,8 @@ class vmmAddHardware(vmmGObjectUI):
> >          model.clear()
> >  
> >          # [xml value, label, conn details]
> > -        model.append(["spicevmc", "Spice channel", False])
> > -        model.append(["tcp", "TCP", True])
> > +        model.append(["spicevmc", _("Spice channel"), False])
> > +        model.append(["tcp", _("TCP"), True])
> > 
> 
> TCP is an acronym and probably shouldn't be translated
> 
[...]
> 
> > diff --git a/virtManager/netlist.py b/virtManager/netlist.py
> > index 013ee4e..58f3c9a 100644
> > --- a/virtManager/netlist.py
> > +++ b/virtManager/netlist.py
> > @@ -90,10 +90,10 @@ class vmmNetworkList(vmmGObjectUI):
> >          combo.set_model(model)
> >          uiutil.init_combo_text_column(combo, 1)
> >  
> > -        model.append(["bridge", "Bridge"])
> > -        model.append(["vepa", "VEPA"])
> > -        model.append(["private", "Private"])
> > -        model.append(["passthrough", "Passthrough"])
> > +        model.append(["bridge", _("Bridge")])
> > +        model.append(["vepa", _("VEPA")])
> 
> Another acronym

I am wondering if this could need to be written in a different script in
some languages? (and fwiw, while I don't think this applies to computer
terms, some acronyms can have translations, UN is ONU in French, AIDS is
SIDA, ...)

Christophe

signature.asc
Description: PGP signature

_______________________________________________
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list