Pavel. On Mon, May 30, 2016 at 5:08 PM, Pavel Grunt <[email protected]> wrote: > Hi, > > These patches changes/improves/add warning messages when a problem occurs > during > parsing of hotkeys. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1339572 > > Changes since v1: > - Added tests > - Added a warning when hotkey's value is invalid > > Thanks, > > Pavel Grunt (5): > Include virt-viewer-util where needed > app: Use debug to inform about smartcard shortcuts state > tests: Add hotkeys test > app: Check validity of hotkey value > app: Inform about problematic hotkey > > src/remote-viewer-main.c | 1 + > src/remote-viewer.c | 1 + > src/virt-viewer-app.c | 11 ++-- > src/virt-viewer-app.h | 1 - > src/virt-viewer-auth.c | 1 + > src/virt-viewer-auth.h | 1 - > src/virt-viewer-main.c | 1 + > src/virt-viewer.c | 1 + > tests/Makefile.am | 12 ++++- > tests/test-hotkeys.c | 127 > +++++++++++++++++++++++++++++++++++++++++++++++ > 10 files changed, 151 insertions(+), 6 deletions(-) > create mode 100644 tests/test-hotkeys.c > > -- > 2.8.3 > > _______________________________________________ > virt-tools-list mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/virt-tools-list
Thanks for the series. Some of the patches (the most part of them) look good enough to go as they are. One of the patches will need a bigger change. Feel free to just resubmit that one instead of the whole series. The patches with minor comments, feel free to change them to address the comments before pushing the series, IOw, no need to resend those. Best Regards, -- Fabiano Fidêncio _______________________________________________ virt-tools-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-tools-list
