On 06/11/2018 12:00 PM, Stefan Berger wrote: > On 06/11/2018 11:54 AM, Cole Robinson wrote: >> On 06/08/2018 05:42 PM, Stefan Berger wrote: >>> Show the TPM device model and allow updating it. If a TPM 1.2 has been >>> chosen, we only allow the TIS interface to be selected. In case of a >>> TPM 2.0 we also enable the choice of the CRB interface. >>> >> Patches look good, thanks. One question here though: is this something >> we actually expect end users to change for an existing VM? What's the > > One use case would be related to an OS (like Win) not liking the TIS > interface for some reason with a TPM 2 but it wants the CRB instead. > It's a real-world use case. > > Otherwise I added it because I wanted to see what interface had been > defined and had a read-only interface first. Then I saw what the > networking page etc. offered and thought I'd do the same rather than > having to force a user to remove the device and add it with a different > interface.
Okay cool, I pushed this series with a small tweak to the test suite in patch #2 so we don't fail on non-latest libvirt Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
