On 10/01/2018 02:53 PM, Marc-André Lureau wrote:
Hi

On Mon, Oct 1, 2018 at 9:20 PM Cole Robinson <crobi...@redhat.com> wrote:

On 09/17/2018 06:59 AM, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau <marcandre.lur...@redhat.com>

Allow to set some memory backing options, ex:
--memorybacking access_mode=shared,source_type=anonymous

Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
---
   .../cli-test-xml/compare/virt-install-singleton-config-2.xml  | 4 ++++
   tests/clitest.py                                              | 2 +-
   virtinst/cli.py                                               | 2 ++
   virtinst/domain/memorybacking.py                              | 2 ++
   4 files changed, 9 insertions(+), 1 deletion(-)

Patch looks good, thanks. I'll push after libvirt patches land

The attributes/properties set here are long supported by libvirt.

Only the value "memfd" for source_type I use in the test isn't yet supported.

thanks


Oh I must have screwed up grepping, I thought source type= was new. I'll push it but with memfd switched to anonymous... doesn't seem to cause an issue that 'memfd' is passed but libvirt doesn't support it yet, which is a bit strange, usually it chokes on unknown enum values

- Cole

_______________________________________________
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list

Reply via email to