> -----Original Message----- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, September 13, 2016 5:23 PM > To: Gonglei (Arei) > Cc: qemu-de...@nongnu.org; virtio-dev@lists.oasis-open.org; Huangpeng > (Peter); Luonengjun; m...@redhat.com; stefa...@redhat.com; > pbonz...@redhat.com; Huangweidong (C); mike.cara...@nxp.com; > ag...@suse.de; xin.z...@intel.com; Claudio Fontana; nmo...@kalray.eu; > vincent.jar...@6wind.com > Subject: Re: [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff > > On Tue, Sep 13, 2016 at 11:52:09AM +0800, Gonglei wrote: > > In previous patch, we define CryptoLegacyHWOptions in > > qapi-schema.json. we introduce the new/delete funciton > > about crypto legacy hardware device. > > Isn't virtio-crypto / cryptodev an entirely new specification ?
Yes, it's an complete new device. > I'm surprised to be seeing something completely new described > as "legacy". Can you explain this in more detail. > Because there are two kind of crypto device, one is virtio-crypto which is a virtual crypto device (And virtio-crypto device is a real crypto device seen by the guest). The other is cryptodev backend device. I have no good idea to name the kind of virtio-crypto device, so named to legacy crypto device refer to Net stuff. Do you have any suggestion? Thanks! Regards, -Gonglei > Regards, > Daniel > -- > |: http://berrange.com -o- > http://www.flickr.com/photos/dberrange/ :| > |: http://libvirt.org -o- > http://virt-manager.org :| > |: http://autobuild.org -o- > http://search.cpan.org/~danberr/ :| > |: http://entangle-photo.org -o- > http://live.gnome.org/gtk-vnc :|
