On Sat, Mar 3, 2018 at 3:31 AM, Jiri Pirko <j...@resnulli.us> wrote: > Fri, Mar 02, 2018 at 08:42:47PM CET, m...@redhat.com wrote: >>On Fri, Mar 02, 2018 at 05:20:17PM +0100, Jiri Pirko wrote: >>> >Yeah, this code essentially calls out the "shareable" code with a >>> >comment at the start and end of the section what defines the >>> >virtio_bypass functionality. It would just be a matter of mostly >>> >cutting and pasting to put it into a separate driver module. >>> >>> Please put it there and unite the use of it with netvsc. >> >>Surely, adding this to other drivers (e.g. might this be handy for xen >>too?) can be left for a separate patchset. Let's get one device merged >>first. > > Why? Let's do the generic infra alongside with the driver. I see no good > reason to rush into merging driver and only later, if ever, to convert > it to generic solution. On contrary. That would lead into multiple > approaches and different behavious in multiple drivers. That is plain > wrong.
If nothing else it doesn't hurt to do this in one driver in a generic way, and once it has been proven to address all the needs of that one driver we can then start moving other drivers to it. The current solution is quite generic, that was my contribution to this patch set as I didn't like how invasive it was being to virtio and thought it would be best to keep this as minimally invasive as possible. My preference would be to give this a release or two in virtio to mature before we start pushing it onto other drivers. It shouldn't take much to cut/paste this into a new driver file once we decide it is time to start extending it out to other drivers. - Alex --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org
