On Thu, Feb 09, 2023 at 12:45:42AM +0200, Alvaro Karsz wrote: > Maybe we should do something more future friendly. > We may want to add more coalescing related features in the future. > * Maybe max/min sets? > * Maybe to offload the adaptive algo to the DPU? > > It will require more feature bits.. > > We could rename this new feature from VIRTIO_NET_F_PERQUEUE_NOTF_COAL > to something like VIRTIO_NET_F_ADVANCED_NOTF_COAL, and introduce a new > bitmask in the virto_net_config. > > We can implement just one bit at first. > BIT 0 - device supports per queue coalescing sets > > Then, we could add more features in the future without having to use > more feature bits. > > Every device that offers VIRTIO_NET_F_ADVANCED_NOTF_COAL should > maintain a valid bitmask.
Without at least two bits there it sounds like over-engineering to me: we won't really know whether the fancy infrastructure is good for any extensions. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org
