On Tue, Feb 21, 2023 at 04:50:56PM +0000, Parav Pandit wrote: > > > From: Heng Qi <hen...@linux.alibaba.com> > > Sent: Tuesday, February 21, 2023 11:44 AM > > > > Patch-1 to introduce the feature bit, description, and link to CVQ > > > dependency. > > > Patch-2 for its link in virtio_net_config structure and description. > > > Patch-3 for new command touching control VQ pieces. > > > > Yes, and you seem to have missed my other replies in this thread:), I > > rephrased > Was it comment "And virtio_net_hash_config seems to suffice except for le16 > reserved[4]." ? > I don’t see these reserved fields in the current structure. > > > it here: > > virtio_net_hash_config seems to be reusable, as the v9 patch is doing, why > > don't we re-use it? > > The reason I can think of is to not expand the virtio_net_hash_config > > structure, > > just set a separate structure for VIRTIO_NET_F_HASH_TUNNEL and include > > hash_tunnel_types? > > The part that I am missing is, how do to reuse virtio_net_hash_config and say > ignore all the existing fields related to rss, but only consider > hash_tunnel_types?
Like a union? The answer is, don't. Just lay out fields one after another. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org
