On Sat, Feb 25 2023, "Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Sun, Feb 26, 2023 at 12:29:58AM +0200, Parav Pandit wrote: >> Legacy interface PCI Device layout description has following issues. >> >> 1. repeated 'structure' word >> 2. virtio header was defined the 0.9.5 spec. It is referred with >> different keywards in this section with multiple different words >> as (a) virtio header, (b) general headers, (c) legacy configuration >> structure, (d) virtio common configuration structure and >> (e) other fields. >> 3. Driver and device requirements listing is intermixed. >> 4. spelling error of structure >> 5. Legacy interface common configuration requirements are not adjacent >> to 1.x comm >> >> Hence, this short series overcomes above issues. > > Looking at the patchset so far I'm inclined to say - leave > legacy well alone. This is not an improvement. > > Gratituis changes for trivial benefit have a cost - people have to > re-read spec this to see what changed. Making things significantly > easier for new readers would make it worth it. As it stands - this is > not worth it. I think I agree. --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org
