On Tue, Mar 28 2023, Parav Pandit <pa...@nvidia.com> wrote: > Currently specification uses virtqueue index and number > interchangeably to refer to the virtqueue. > > It is better to always refer to it the virtqueue in consistent manner. > > Two registers QueueNumMax and QueueNum actually reflects the queue size > or queue depth indicating max and actual number of entries in the queue. > > These are further named differently between pci and mmio transport. > PCI transport indicates queue size as queue_size. > > To bring consistency between pci and mmio transport, and to avoid > confusion between number and index, rename the QueueNumMax and QueueNum > registers to QueueSizeMax and QueueSize respectively. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 > Reviewed-by: Jiri Pirko <j...@nvidia.com> > Signed-off-by: Parav Pandit <pa...@nvidia.com> > > --- > changelog: > v8->v9: > - added field tag to indicate field name instead of English word > v0->v1: > - replaced references of QueueNumMax to QueueSizeMax > - replaced references of QueueNum to QueueSize > - added note for renamed fields old name suggested by @Michael Tsirkin > --- > transport-mmio.tex | 44 ++++++++++++++++++++++++++++++-------------- > 1 file changed, 30 insertions(+), 14 deletions(-) > > diff --git a/transport-mmio.tex b/transport-mmio.tex > index f884a2c..9b450b8 100644 > --- a/transport-mmio.tex > +++ b/transport-mmio.tex > @@ -110,24 +110,32 @@ \subsection{MMIO Device Register > Layout}\label{sec:Virtio Transport Options / Vi > \hline > \mmioreg{QueueSel}{Virtual queue index}{0x030}{W}{% > Writing to this register selects the virtual queue that the > - following operations on \field{QueueNumMax}, \field{QueueNum}, > \field{QueueReady}, > + following operations on \field{QueueSizeMax}, > + \field{QueueSize}, \field{QueueReady},
I'm not sure it is worthwile keeping the lines short so aggressively (after all, it does not affect the generated html/pdf), especially as it makes the diff a bit harder to read, but I don't have a strong objection to it. On the whole, Reviewed-by: Cornelia Huck <coh...@redhat.com> --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org
