On Wed, Jul 12 2023, Heng Qi <hen...@linux.alibaba.com> wrote: > 在 2023/7/12 下午8:42, Cornelia Huck 写道: >> On Wed, Jul 12 2023, "Michael S. Tsirkin" <m...@redhat.com> wrote: >> >>> On Wed, Jul 12, 2023 at 02:22:26PM +0200, Cornelia Huck wrote: >>>> On Mon, Jul 03 2023, Heng Qi <hen...@linux.alibaba.com> wrote: >>>> >>>> (...) >>>> >>>>> +\paragraph{Inner Header Hash} >>>>> +\label{sec:Device Types / Network Device / Device Operation / Processing >>>>> of Incoming Packets / Inner Header Hash} >>>>> + >>>>> +If VIRTIO_NET_F_HASH_TUNNEL has been negotiated, the driver can send the >>>>> command >>>>> +VIRTIO_NET_CTRL_HASH_TUNNEL_SET to configure the calculation of the >>>>> inner header hash. >>>>> + >>>>> +struct virtnet_hash_tunnel { >>>>> + le32 enabled_tunnel_types; >>>>> +}; >>>>> + >>>>> +#define VIRTIO_NET_CTRL_HASH_TUNNEL 7 >>>>> + #define VIRTIO_NET_CTRL_HASH_TUNNEL_SET 0 >>>> This needs to be wrapped in \begin{lstlisting}..\end{lstlisting}, can do >>>> so when applying. >>>> >>>> (...) >>>> >>>>> +Encapsulation types applicable for inner header hash: >>>>> +\begin{lstlisting} >>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_GRE_2784 (1 << 0) /* >>>>> \hyperref[intro:gre_rfc2784]{[GRE_rfc2784]} */ >>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_GRE_2890 (1 << 1) /* >>>>> \hyperref[intro:gre_rfc2890]{[GRE_rfc2890]} */ >>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_GRE_7676 (1 << 2) /* >>>>> \hyperref[intro:gre_rfc7676]{[GRE_rfc7676]} */ >>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_GRE_UDP (1 << 3) /* >>>>> \hyperref[intro:gre_in_udp_rfc8086]{[GRE-in-UDP]} */ >>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_VXLAN (1 << 4) /* >>>>> \hyperref[intro:vxlan]{[VXLAN]} */ >>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_VXLAN_GPE (1 << 5) /* >>>>> \hyperref[intro:vxlan_gpe]{[VXLAN-GPE]} */ >>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_GENEVE (1 << 6) /* >>>>> \hyperref[intro:geneve]{[GENEVE]} */ >>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_IPIP (1 << 7) /* >>>>> \hyperref[intro:ipip]{[IPIP]} */ >>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_NVGRE (1 << 8) /* >>>>> \hyperref[intro:nvgre]{[NVGRE]} */ >>>>> +\end{lstlisting} >>>> I'm afraid this one doesn't come out quite as intended, we'll end up >>>> with verbatim "\hyperref" text instead of a link. Anyone have a good >>>> idea on how to fix that? >>>> >>>> I'd prefer to push this now with the first issue addressed and to do an >>>> (editorial) patch on top to deal with the second issue (unless someone >>>> can come up with a really trivial fix for it, then I can apply that >>>> straightaway.) >>> Someone suggested using escapechar: >>> https://tex.stackexchange.com/questions/314903/inline-links-in-code-listings >>> >>> Didn't try. >> Looks reasonable (and also revealed a typo for VXLAN-GPE). I think I'll >> go ahead with this one. > > Yes. "intro:vxlan_gpe" -> "intro:vxlan-gpe". > > May I ask if the fix to these two problems is for me to make fix patches > or for you to solve it when editing?
I'd fix it myself while applying, but... ...while the changes above give me a fine pdf, the html generated is broken. The problem seems to originate in the normative references that are added in introduction.tex, but I don't see where it goes astray. [401] [402] [403] [404] (./virtio-v1.2-cs01.aux ! Missing \endcsname inserted. <to be read again> \unhbox l.49 ...ction}Normative References}}{section.1}{}} ? ! Emergency stop. <to be read again> \unhbox l.49 ...ction}Normative References}}{section.1}{}} (makehtml.sh on master seems to work ok, so it's something in this patch...) Does anyone else manage to spot the problem? --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org