"Michael S. Tsirkin" <[email protected]> writes: > On Mon, Nov 07, 2022 at 12:14:07PM +0000, Alex Bennée wrote: >> The previous fix to virtio_device_started revealed a problem in its >> use by both the core and the device code. The core code should be able >> to handle the device "starting" while the VM isn't running to handle >> the restoration of migration state. To solve this duel use introduce a >> new helper for use by the vhost-user backends who all use it to feed a >> should_start variable. >> >> We can also pick up a change vhost_user_blk_set_status while we are at >> it which follows the same pattern. >> >> Fixes: 9f6bcfd99f (hw/virtio: move vm_running check to virtio_device_started) >> Signed-off-by: Alex Bennée <[email protected]> >> Cc: "Michael S. Tsirkin" <[email protected]> > > Hi Alex, did you actually check this under gitlab CI?
It's had a clean pass as part of my for-7.2/misc-fixes branch but I've been unable to replicate the crash it was meant to fix locally as of yet. https://gitlab.com/stsquad/qemu/-/pipelines/687366712 -- Alex Bennée _______________________________________________ Virtio-fs mailing list [email protected] https://listman.redhat.com/mailman/listinfo/virtio-fs
