On Tue, Apr 18, 2023 at 05:21:33PM +0100, Alex Bennée wrote: > Lets document some more of the core VirtIODevice structure. > > Signed-off-by: Alex Bennée <[email protected]> > --- > include/hw/virtio/virtio.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > index 1ba7a9dd74..ef77e9ef0e 100644 > --- a/include/hw/virtio/virtio.h > +++ b/include/hw/virtio/virtio.h > @@ -150,10 +150,18 @@ struct VirtIODevice > VMChangeStateEntry *vmstate; > char *bus_name; > uint8_t device_endian; > + /** > + * @user_guest_notifier_mask: gate usage of ->guest_notifier_mask() > callback.
s/user_/use_/ > + * This is used to suppress the masking of guest updates for > + * vhost-user devices which are asynchronous by design. What is the exact reason why masking is not supported by vhost-user? Only vhost-user-net and vhost-user-crypto set use_guest_notifier_mask to false. Do the other vhost-user devices need to set it to false too? > + */ > bool use_guest_notifier_mask; > AddressSpace *dma_as; > QLIST_HEAD(, VirtQueue) *vector_queues; > QTAILQ_ENTRY(VirtIODevice) next; > + /** > + * @config_notifier: the event notifier that handles config events Using VIRTIO spec terminology: "the event notifier that sends Configuration Change Notifications" > + */ > EventNotifier config_notifier; > }; > > -- > 2.39.2 >
signature.asc
Description: PGP signature
_______________________________________________ Virtio-fs mailing list [email protected] https://listman.redhat.com/mailman/listinfo/virtio-fs
