On 7/15/23 12:31, Rob Wing wrote:
On Saturday, July 15, 2023, Matthew Grooms <[email protected]
<mailto:[email protected]>> wrote:
We'll overlook the fact that it does attempt to consolidate files (
2 vs 3 ) and that there's no feedback requesting further
consolidation after being open for two years, but noted.
You may as well abandon https://reviews.freebsd.org/D29262
<https://reviews.freebsd.org/D29262>, for these reasons alone:
Thanks for the feedback. In the future, please feel free to add your
concerns to the code review. It would be extremely helpful.
- JSON doesn't support storing binary data
I don't know how to state it more clearly: Making binary copies of the
data structures is the problem. Something tells me that you'll continue
to ignore this, so I'll stop saying it.
- a snapshot should be contained in a single file
Heard. A single file.
The UPB patch addresses the above. Vitaliy's patch does nothing to
address any of it. If one is going to be proposed as an alternative
to the other, it better solve the same problems as then some.
The UBP patch is not an alternative - show me another hypervisor that
uses JSON as their snapshot format.
Heard. JSON is bad.
The silence is real.
No, it's not. I've given you feedback multiple times.
I'm very aware. The silence I was referring to wasn't yours. Feel free
to re-read for context.
Rob, I'm not hear to argue with you. I've shared all the opinions I feel
are relevant to the file format proposal and would prefer not to waste
the list's time.
Thanks,
-Matthew
