On Friday 18 April 2008 13:24:27 Herbert Xu wrote:
> Finally this patch lets virtio_net receive GSO packets in addition
> to sending them.
...
> static void try_fill_recv(struct virtnet_info *vi)
> {
> struct sk_buff *skb;
> - struct scatterlist sg[1+MAX_SKB_FRAGS];
> + struct scatterlist sg[2+MAX_SKB_FRAGS];
> int num, err;
I'm not sure what the right number is here. Say worst case is header which
goes over a page boundary then MAX_SKB_FRAGS in the skb, but for some reason
that already has a +2:
/* To allow 64K frame to be packed as single skb without frag_list */
#define MAX_SKB_FRAGS (65536/PAGE_SIZE + 2)
Unless someone explains, I'll change the xmit sg to 2+MAX_SKB_FRAGS as well.
Thanks,
Rusty.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization
