On 5/25/2011 4:20 PM, Arnd Bergmann wrote: > On Wednesday 25 May 2011 21:18:05 Chris Metcalf wrote: >> The contents of the hardwall ID file are then just a cpulist of the cpus >> covered by the hardwall, rather than introducing a new convention (as >> quoted above, e.g. "2x2 1,1"). Individual tasks that are in the hardwall >> can be found by reading the "hardwall" files, and we can learn where they >> are bound in the hardwall by reading the "stat" file as is normal for >> learning process affinity. > Be careful with listing PID values in the hardwall files, as the PIDs > may not be unique or visible if you combine this with PID name spaces. > I guess the right solution would be to only list the tasks that are > present in the name space of the thread reading the file.
Sorry not to be clearer -- I am no longer listing any PID values in the hardwall files, for that exact reason. You have to look at /proc/*/hardwall (or /proc/*/tasks/*/hardwall) to find the files that are in a particular hardwall. This pattern is not one that's normally directly useful, though, so I'm happy leaving it to userspace if it's desired. >>> When you do a /sys/hypervisor/ interface, put everything into a subdirectory >>> under /sys/hypervisor with the name of your hypervisor, to avoid naming >>> conflicts, e.g. >>> >>> /sys/hypervisor/tilera-hv/board/board_serial > I just checked for other users. The only one I could find was > drivers/xen/sys-hypervisor.c, and it also doesn't use a subdirectory to > identify that hypervisor. It's probably more consistent if you also don't > do it then. > > You can create a directory with multiple files using sysfs_create_group() > as the xen code does, but not nested directories. I'll look into sysfs_create_group(), and then send a revised patch with all the /proc and /sys changes. Thanks! -- Chris Metcalf, Tilera Corp. http://www.tilera.com _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
