On Mon, Sep 10, 2012 at 08:16:54AM +0200, Paolo Bonzini wrote: > Il 09/09/2012 00:40, Michael S. Tsirkin ha scritto: > > On Fri, Sep 07, 2012 at 06:00:50PM +0200, Paolo Bonzini wrote: > >> Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto: > >>> Cc: Stefan Hajnoczi <stefa...@linux.vnet.ibm.com> > >>> Cc: Zhi Yong Wu <wu...@linux.vnet.ibm.com> > >>> Cc: Michael S. Tsirkin <m...@redhat.com> > >>> Cc: Paolo Bonzini <pbonz...@redhat.com> > >>> Signed-off-by: Nicholas Bellinger <n...@linux-iscsi.org> > >>> --- > >>> hw/virtio-pci.c | 2 ++ > >>> hw/virtio-scsi.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ > >>> hw/virtio-scsi.h | 1 + > >>> 3 files changed, 52 insertions(+), 0 deletions(-) > >> > >> Please create a completely separate device vhost-scsi-pci instead (or > >> virtio-scsi-tcm-pci, or something like that). It is used completely > >> differently from virtio-scsi-pci, it does not make sense to conflate the > >> two. > > > > Ideally the name would say how it is different, not what backend it > > uses. Any good suggestions? > > I chose the backend name because, ideally, there would be no other > difference. QEMU _could_ implement all the goodies in vhost-scsi (such > as reservations or ALUA), it just doesn't do that yet. > > Paolo
Then why do you say "It is used completely differently from virtio-scsi-pci"? Isn't it just a different backend? If yes then it should be a backend option, like it is for virtio-net. -- MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
