sjur.brandel...@stericsson.com writes: > From: Sjur Brændeland <sjur.brandel...@stericsson.com> > > Free pending output buffers from the virtio out-queue when > host has acknowledged port_close. Also removed WARN_ON() > in remove_port_data(). > > Signed-off-by: Sjur Brændeland <sjur.brandel...@stericsson.com> > --- > > Resending, this time including a proper "Subject"... > -- > > Hi Amit, > > Note: This patch is compile tested only. I have done the removal > of buffers from out-queue in handle_control_message() > when host has acked the close request. This seems less > racy than doing it in the release function.
This confuses me... why are we doing this in case VIRTIO_CONSOLE_PORT_OPEN:? We can't pull unconsumed buffers out of the ring when the other side may still access it, and this seems to be doing that. Thanks, Rusty. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
