Hi Sjur, On Tue, Apr 23, 2013 at 11:32 AM, Sjur Brændeland <[email protected]> wrote: > Quite frankly I would *really* like to see vringh support in remoteproc > included in 3.10, and I am afraid your suggestion will cause us to miss > the merge window once again. > > How about including my simple, but verbose patch in virtio-next for 3.10. > Then you could post patches that refactors remoteproc and vringh > making the code more elegant and less verbose on top of my patch. > > Doing this iteratively would also make it easy to verify your changes, > and show how your patches reduces overall code size and provides > a more elegant solution.
I realize this is frustrating for you, and I'm sorry about that. You did a great job and I'm sure the patch works great for you. I don't feel the patch is ready for mainline merger at this point though. There's a good chance that eventually not much will be left from this patch as it is mostly a duplication of existing code with very little changes, and I'm afraid that if we do merge it now it's going to be much harder to change things after the fact and this will become a maintainability burden for us. If STE requires this functionality ASAP then this patch can surely be applied out-of-tree - I doubt there's any product out there that is built purely out of vanilla upstream kernel anyway. Please feel free to blame me if there's any internal pressure on you because of this delay. I would also appreciate any help from you (or Dmitry) to try and implement the changes I've outlined, as I'm not sure how much free time I'm going to have which I can dedicate for this work. I'm happy to offer any help to further elaborate or prototype this if needed. Hopefully we can work together towards a satisfactory result. Thanks! Ohad. _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
