On Sun, 5 Oct 2014 19:07:02 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote:
> This is in preparation to extending config changed event handling > in core. > Wrapping these in an API also seems to make for a cleaner code. > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > --- > include/linux/virtio.h | 6 +++++ > drivers/virtio/virtio.c | 53 +++++++++++++++++++++++++++++++++++++++++++ > drivers/virtio/virtio_pci.c | 55 > ++------------------------------------------- > 3 files changed, 61 insertions(+), 53 deletions(-) > > diff --git a/include/linux/virtio.h b/include/linux/virtio.h > index 3c19bd3..8df7ba8 100644 > --- a/include/linux/virtio.h > +++ b/include/linux/virtio.h > @@ -78,6 +78,7 @@ bool virtqueue_is_broken(struct virtqueue *vq); > /** > * virtio_device - representation of a device using virtio > * @index: unique position on the virtio bus > + * @failed: saved value for CONFIG_S_FAILED bit (for restore) > * @dev: underlying device. > * @id: the device type identification (used to match it with a driver). > * @config: the configuration ops for this device. The only minor gripe I have is with the naming of this field: To a cursory reader, it might indicate the current 'failed' status of the device. What about 'saved_failed'? Otherwise, moving this into common virtio code makes sense. Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
