On Mon, Sep 12, 2016 at 06:33:43PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 12, 2016 at 01:10:41PM +0100, Will Deacon wrote: > > Legacy virtio defines the virtqueue base using a 32-bit PFN field, with > > a read-only register indicating a fixed page size of 4k. > > > > This can cause problems for DMA allocators that allocate top down from > > the DMA mask, which is set to 64 bits. In this case, the addresses are > > silently truncated to 44-bit, leading to IOMMU faults, failure to read > > from the queue or data corruption. > > > > This patch restricts the DMA mask for legacy PCI virtio devices to > > 44 bits, which matches the specification. > > > > Cc: Andy Lutomirski <l...@kernel.org> > > Cc: Michael S. Tsirkin <m...@redhat.com> > > Signed-off-by: Will Deacon <will.dea...@arm.com> > > Hmm - IIUC it's actually only the case for the virtio rings > themselves. The buffer addresses put in the rings are full 64 bit ones.
I think that's right, yes. > It so happens that virtio doesn't use coherent allocs except > for the rings. > So I'm inclined to say the coherent mask should be set to 44, > with a comment explaning that this is for the rings. I can certainly add that in v2, along with your suggestion to use 32 + VIRTIO_PCI_QUEUE_ADDR_SHIFT instead of the 44. > In case we start using coherent allocations in virtio, > it might be cleaner to relax the mask after allocating > the rings, but I'm not sure that's allowed by the DMA API. > thoughts? Hmm, that *might* work, but I could certainly imagine some DMA implementations going wrong if they assume the mask is fixed. Will _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
