On Fri, Nov 02, 2018 at 03:24:13PM -0400, Vitaly Mayatskih wrote: > On Fri, Nov 2, 2018 at 2:36 PM Michael S. Tsirkin <m...@redhat.com> wrote: > > > > + if (type == VIRTIO_BLK_T_GET_ID) { > > > + char s[] = "vhost_blk"; > > > > Isn't this supposed to return the serial #? > > Yes, that gets a bit tricky here... Disk serial number is specified in > QEMU command line parameters, so it needs to be passed to vhost_blk > when qemu attaches the disk backend. That can be done (now? in a > following incremental patch?).
I'add an ioctl now. > Also other vhost work does the same with GET_ID, if that's matter. > > I'll fix the rest, thanks for review! > > -- > wbr, Vitaly _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization