On Fri, Aug 09, 2019 at 07:00:26PM +0300, Adalbert Lazăr wrote:
> +++ b/include/linux/page-flags.h
> @@ -417,8 +417,10 @@ PAGEFLAG(Idle, idle, PF_ANY)
>   */
>  #define PAGE_MAPPING_ANON    0x1
>  #define PAGE_MAPPING_MOVABLE 0x2
> +#define PAGE_MAPPING_REMOTE  0x4

Uh.  How do you know page->mapping would otherwise have bit 2 clear?
Who's guaranteeing that?

This is an awfully big patch to the memory management code, buried in
the middle of a gigantic series which almost guarantees nobody would
look at it.  I call shenanigans.

> @@ -1021,7 +1022,7 @@ void page_move_anon_rmap(struct page *page, struct 
> vm_area_struct *vma)
>   * __page_set_anon_rmap - set up new anonymous rmap
>   * @page:    Page or Hugepage to add to rmap
>   * @vma:     VM area to add page to.
> - * @address: User virtual address of the mapping     
> + * @address: User virtual address of the mapping

And mixing in fluff changes like this is a real no-no.  Try again.

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Reply via email to