On 2019/10/16 下午12:57, Parav Pandit wrote:
+static struct mdev_class_id id_table[] = {
static const
+ { MDEV_ID_VFIO },
I guess you don't need extra braces for each entry.
Since this enum represents MDEV class id, it better to name it as
MDEV_CLASS_ID_VFIO.
(Similar to PCI_VENDOR_ID, PCI_DEVICE_ID)..
Gcc start to complain like:
warning: missing braces around initializer [-Wmissing-braces]
static const struct mdev_class_id id_table[] = {
^
MDEV_ID_VFIO, 0,
{ } {
};
}
So I will keep this part untouched.
Thanks
+ { 0 },
+};
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
