Hi Thomas, I love your patch! Yet something to improve:
[auto build test ERROR on next-20200305] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2 v5.6-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base: 47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm64-defconfig (attached as .config) compiler: clang version 11.0.0 (git://gitmirror/llvm_project a0cd413426479abb207381bdbab862f3dfb3ce7d) reproduce: # FIXME the reproduce steps for clang is not ready yet If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>): >> drivers/gpu/drm/tegra/rgb.c:281:2: error: implicit declaration of function >> 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, &output->encoder, DRM_MODE_ENCODER_LVDS); ^ drivers/gpu/drm/tegra/rgb.c:281:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/tegra/hdmi.c:1445:2: error: implicit declaration of function >> 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, &hdmi->output.encoder, ^ drivers/gpu/drm/tegra/hdmi.c:1445:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/tegra/dsi.c:1058:3: error: implicit declaration of function >> 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, &dsi->output.encoder, ^ drivers/gpu/drm/tegra/dsi.c:1058:3: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/tegra/sor.c:3102:2: error: implicit declaration of function >> 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, &sor->output.encoder, encoder); ^ drivers/gpu/drm/tegra/sor.c:3102:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. vim +/drm_simple_encoder_init +281 drivers/gpu/drm/tegra/rgb.c 266 267 int tegra_dc_rgb_init(struct drm_device *drm, struct tegra_dc *dc) 268 { 269 struct tegra_output *output = dc->rgb; 270 int err; 271 272 if (!dc->rgb) 273 return -ENODEV; 274 275 drm_connector_init(drm, &output->connector, &tegra_rgb_connector_funcs, 276 DRM_MODE_CONNECTOR_LVDS); 277 drm_connector_helper_add(&output->connector, 278 &tegra_rgb_connector_helper_funcs); 279 output->connector.dpms = DRM_MODE_DPMS_OFF; 280 > 281 drm_simple_encoder_init(drm, &output->encoder, > DRM_MODE_ENCODER_LVDS); 282 drm_encoder_helper_add(&output->encoder, 283 &tegra_rgb_encoder_helper_funcs); 284 285 drm_connector_attach_encoder(&output->connector, 286 &output->encoder); 287 drm_connector_register(&output->connector); 288 289 err = tegra_output_init(drm, output); 290 if (err < 0) { 291 dev_err(output->dev, "failed to initialize output: %d\n", err); 292 return err; 293 } 294 295 /* 296 * Other outputs can be attached to either display controller. The RGB 297 * outputs are an exception and work only with their parent display 298 * controller. 299 */ 300 output->encoder.possible_crtcs = drm_crtc_mask(&dc->base); 301 302 return 0; 303 } 304 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
_______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
