On Wed, Mar 16, 2022 at 12:20:09PM -0700, Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > names to eliminate the anonymous names. > > Example 1: (System.map) > ffffffff832fc78c t init > ffffffff832fc79e t init > ffffffff832fc8f8 t init > > Example 2: (initcall_debug log) > calling init+0x0/0x12 @ 1 > initcall init+0x0/0x12 returned 0 after 15 usecs > calling init+0x0/0x60 @ 1 > initcall init+0x0/0x60 returned 0 after 2 usecs > calling init+0x0/0x9a @ 1 > initcall init+0x0/0x9a returned 0 after 74 usecs > > Fixes: 64b94ceae8c1 ("crypto: blowfish - add x86_64 assembly implementation") > Fixes: 676a38046f4f ("crypto: camellia-x86_64 - module init/exit functions > should be static") > Fixes: 0b95ec56ae19 ("crypto: camellia - add assembler implementation for > x86_64") > Fixes: 56d76c96a9f3 ("crypto: serpent - add AVX2/x86_64 assembler > implementation of serpent cipher") > Fixes: b9f535ffe38f ("[CRYPTO] twofish: i586 assembly version") > Fixes: ff0a70fe0536 ("crypto: twofish-x86_64-3way - module init/exit > functions should be static") > Fixes: 8280daad436e ("crypto: twofish - add 3-way parallel x86_64 assembler > implemention") > Signed-off-by: Randy Dunlap <rdun...@infradead.org> > Cc: Jussi Kivilinna <jussi.kivili...@mbnet.fi> > Cc: Joachim Fritschi <jfrits...@freenet.de> > Cc: Herbert Xu <herb...@gondor.apana.org.au> > Cc: "David S. Miller" <da...@davemloft.net> > Cc: linux-cry...@vger.kernel.org > Cc: x...@kernel.org > --- > arch/x86/crypto/blowfish_glue.c | 8 ++++---- > arch/x86/crypto/camellia_glue.c | 8 ++++---- > arch/x86/crypto/serpent_avx2_glue.c | 8 ++++---- > arch/x86/crypto/twofish_glue.c | 8 ++++---- > arch/x86/crypto/twofish_glue_3way.c | 8 ++++---- > 5 files changed, 20 insertions(+), 20 deletions(-)
Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization