On Fri, Apr 07, 2023 at 04:08:30PM -0700, Guenter Roeck wrote:
> On 4/7/23 08:01, Krzysztof Kozlowski wrote:
> > Statically allocated array of pointed to hwmon_channel_info can be made
> > const for safety.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>
> >
> > ---
> >
> > This depends on hwmon core patch:
> > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlow...@linaro.org/
> >
> > Therefore I propose this should also go via hwmon tree.
>
> I am not going to apply patches for 10+ subsystems through the hwmon tree.
> This can only result in chaos. The dependent patch is available at
>
> git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
> hwmon-const
Doesn't it cause build errors or warnings there?
> or wait until after the next commit window to apply this patch.
>
> Thanks,
> Guenter
>
> >
> > Cc: Jean Delvare <jdelv...@suse.com>
> > Cc: Guenter Roeck <li...@roeck-us.net>
> > Cc: linux-hw...@vger.kernel.org
> > ---
> > drivers/vdpa/solidrun/snet_hwmon.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/vdpa/solidrun/snet_hwmon.c
> > b/drivers/vdpa/solidrun/snet_hwmon.c
> > index e695e36ff753..65304354b34a 100644
> > --- a/drivers/vdpa/solidrun/snet_hwmon.c
> > +++ b/drivers/vdpa/solidrun/snet_hwmon.c
> > @@ -159,7 +159,7 @@ static const struct hwmon_ops snet_hwmon_ops = {
> > .read_string = snet_hwmon_read_string
> > };
> > -static const struct hwmon_channel_info *snet_hwmon_info[] = {
> > +static const struct hwmon_channel_info * const snet_hwmon_info[] = {
> > HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT | HWMON_T_MAX | HWMON_T_CRIT |
> > HWMON_T_LABEL,
> > HWMON_T_INPUT | HWMON_T_CRIT | HWMON_T_LABEL),
> > HWMON_CHANNEL_INFO(power, HWMON_P_INPUT | HWMON_P_LABEL),
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
