On Fri, Jun 30, 2023 at 06:36:56PM +0800, Zhu Lingshan wrote:
> This commits synchronizes irqs when free them
> 
> Signed-off-by: Zhu Lingshan <lingshan....@intel.com>
> Tested-by: Cindy Lu <l...@redhat.com>
> ---
>  drivers/vdpa/virtio_pci/vp_vdpa.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c 
> b/drivers/vdpa/virtio_pci/vp_vdpa.c
> index 281287fae89f..d8ee3e68cd2d 100644
> --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> @@ -116,6 +116,7 @@ static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa)
>       for (i = 0; i < vp_vdpa->queues; i++) {
>               if (vp_vdpa->vring[i].irq != VIRTIO_MSI_NO_VECTOR) {
>                       vp_modern_queue_vector(mdev, i, VIRTIO_MSI_NO_VECTOR);
> +                     synchronize_irq(vp_vdpa->vring[i].irq);
>                       devm_free_irq(&pdev->dev, vp_vdpa->vring[i].irq,
>                                     &vp_vdpa->vring[i]);
>                       vp_vdpa->vring[i].irq = VIRTIO_MSI_NO_VECTOR;
> @@ -124,6 +125,7 @@ static void vp_vdpa_free_irq(struct vp_vdpa *vp_vdpa)
>  
>       if (vp_vdpa->config_irq != VIRTIO_MSI_NO_VECTOR) {
>               vp_modern_config_vector(mdev, VIRTIO_MSI_NO_VECTOR);
> +             synchronize_irq(vp_vdpa->config_irq);
>               devm_free_irq(&pdev->dev, vp_vdpa->config_irq, vp_vdpa);
>               vp_vdpa->config_irq = VIRTIO_MSI_NO_VECTOR;


Weird, doesn't free_irq synchronize automatically?

>       }
> -- 
> 2.39.3

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Reply via email to