On 11/2/26 02:21, Michal Luczaj wrote: > On 10/30/26 21:30, Bobby Eshleman wrote: >>> virtio_vsock_reset_sock() and vhost_vsock_reset_orphans() are my pet >>> peeves: state switcheroo without taking lock_sock(). Which, again, races >>> vsock_connect(). >> >> True, I don't love that either, but I feel the impact is at least >> constrained by the fact that it only happens when the module or device >> is already going away. > > Doesn't it happen on suspend as well? Is so, with a poorly timed connect() > things can go south on resume.
What I wrote doesn't really make sense, does it? vsock_connect() cannot freeze midway, so SS_UNCONNECTED (due to virtio_vsock_reset_sock() flipping state to TCP_CLOSE) can't be set. Sorry. But it is still the case for bind/unbind, right?
