Hi, Massimo Nuvoli wrote:
> This patch corrects a lot of possibile "segmentation fault" in the code.
>
Umm... what's this:
if (!ast_chan)
+ {
+ ast_log(LOG_WARNING, "Unexpexted ast_chan NULL\n");
return;
+ }
ast_mutex_lock(&ast_chan->lock);
+
+ if (!ast_chan)
+ {
+ ast_log(LOG_WARNING, "Unexpexted ast_chan NULL\n");
+ return;
+ }
+
The second hunk, testing ast_chan again after ast_mutex_lock(), does make
no sense whatsoever. You have a few other places where you do this.
- if (module->tty->flip.count >=
+ if (module->tty->max_flip_cnt >=
Shouldn't that depend on the kernel version? max_flip_cnt actually seems
to be unused (i.e. always zero) in the current (v2.6.18rc2) kernel.
--
Matthias Urlichs | {M:U} IT Design @ m-u-it.de | [EMAIL PROTECTED]
Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de
- -
BOFH excuse #233:
TCP/IP UDP alarm threshold is set too low.
_______________________________________________
Visdn-hackers mailing list
[email protected]
https://mailman.uli.it/mailman/listinfo/visdn-hackers
