François Cartegnie pushed to branch master at VideoLAN / VLC
Commits:
04ee1883 by Fatih Uzunoglu at 2024-08-30T08:12:54+00:00
qt: clear qml type registrations within `MainUI` destruction
QML types need to be cleared for two reasons:
- Protected modules do not allow new type registrations.
- It does not make sense to re-register same types.
This is currently the case if a compositor fails when
initializing the quick view.
Note that `qmlClearTypeRegistrations()` is effective on
protected modules as well.
It is a known bug from Qt's side that once Qt Quick view
(engine) is fully initialized, re-initialization is flaky
and causes crashes. See QTBUG-113274. Unfortunately this
does not fix that issue.
- - - - -
1 changed file:
- modules/gui/qt/maininterface/mainui.cpp
Changes:
=====================================
modules/gui/qt/maininterface/mainui.cpp
=====================================
@@ -153,7 +153,7 @@ MainUI::MainUI(qt_intf_t *p_intf, MainCtx *mainCtx,
QWindow* interfaceWindow, Q
MainUI::~MainUI()
{
-
+ qmlClearTypeRegistrations();
}
bool MainUI::setup(QQmlEngine* engine)
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/04ee1883b083f35f4bf56c3e2476e170581e4603
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/04ee1883b083f35f4bf56c3e2476e170581e4603
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance_______________________________________________
vlc-commits mailing list
[email protected]
https://mailman.videolan.org/listinfo/vlc-commits
