Steve Lhomme pushed to branch master at VideoLAN / VLC
Commits:
8d8f6182 by Fatih Uzunoglu at 2026-01-08T16:19:21+00:00
Revert "qt: call `vlc_window_ReportSize()` before the video surface changes are
committed"
This reverts commit a8cc3f6db15da074287fcd6cb9fdb7d938fff971.
Since report size is asynchronous, the idea was to report the size preemptively
to not
wait for the compositor to actually adjust the video window so that the video
window
would not be adjusted too early, particularly before the video is adjusted.
However,
this turned out to be problematic with HWND window type.
This approach is also technically incorrect, because report size expects the
current
size of the window and not the pending size. Preemptive reporting violates such
expectation.
- - - - -
1 changed file:
- modules/gui/qt/maininterface/videosurface.cpp
Changes:
=====================================
modules/gui/qt/maininterface/videosurface.cpp
=====================================
@@ -112,9 +112,9 @@ void VideoSurfaceProvider::onSurfacePropertiesChanged(const
std::optional<QSizeF
const
std::optional<QPointF>& position,
const
std::optional<qreal>& scale)
{
+ emit surfacePropertiesChanged(size, position, scale);
if (m_voutWindow && size)
vlc_window_ReportSize(m_voutWindow, std::ceil(size->width()),
std::ceil(size->height()));
- emit surfacePropertiesChanged(size, position, scale);
}
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/8d8f6182cce6e7d8042cdfb45d853d4b52fc0b59
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/8d8f6182cce6e7d8042cdfb45d853d4b52fc0b59
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance_______________________________________________
vlc-commits mailing list
[email protected]
https://mailman.videolan.org/listinfo/vlc-commits
