On Wed, 17 Jan 2001, Peter Prymmer wrote:
> And it could very well be that a bug in configure.com prevents the
> $ subversion="0" assignment from kicking in.
There was a bug but my speculation was not on the mark. Our read
patchlevel.h conditional would quit reading before it necessarily found
the various API macros was the problem.
> Perhaps another thing worth testing is what munchconfig.exe and
> descrip.mms would do with:
>
> PERL_SUBVERSION=0
Sans 'quotes' munchconfig and mms seem pretty happy, will mmk be happy
too?
> I'll try to look into it.
And here is the patch that supercedes Craig's (MMK users and external
module builders of either the mms or mmk persuasion may want to test this
out). POSIX compliant platform folks may want to laugh at the verbosity
of DCL since all of this just replaces the wee little awk one liner from
the Bourne-ish Configure:
$test -f $src/patchlevel.h && \
awk '/^#define[ ]+PERL_/ {printf "%s=%s\n",$2,$3}' $src/patchlevel.h
>>config.sh
OK here it is w.r.t. 8453:
--- configure.com.orig Wed Jan 17 12:08:15 2001
+++ configure.com Wed Jan 17 12:44:15 2001
@@ -1224,12 +1224,20 @@
$ api_subversion = F$ELEMENT(2," ",line)
$ got_api_subversion = "true"
$ ENDIF
-$ IF (.NOT.got_patch).OR.(.NOT.got_sub) THEN GOTO Patchlevel_h_loop
+$ IF (.NOT. got_patch) .OR. -
+ (.NOT. got_sub) .OR. -
+ (.NOT. got_api_revision) .OR. -
+ (.NOT. got_api_version) .OR. -
+ (.NOT. got_api_subversion) -
+ THEN GOTO Patchlevel_h_loop
$Close_patch:
$ CLOSE CONFIG
$ ELSE
$ patchlevel="0"
$ subversion="0"
+$ api_revision="0"
+$ api_version="0"
+$ api_subversion="0"
$ ENDIF
$ IF (F$STRING(subversion) .NES. "0")
$ THEN
@@ -4835,8 +4843,11 @@
$ WC "CONFIG='true'"
$ WC "Makefile_SH='" + Makefile_SH + "'"
$ WC "Mcc='" + Mcc + "'"
-$! WC "PERL_SUBVERSION='" + subversion + "'" ! VMS specific to descrip_mms.template
-$ WC "PERL_VERSION='" + patchlevel + "'" ! VMS specific to descrip_mms.template
+$ WC "PERL_REVISION=" + revision
+$ WC "PERL_VERSION=" + patchlevel
+$ WC "PERL_SUBVERSION=" + subversion
+$ WC "PERL_API_VERSION=" + api_version
+$ WC "PERL_API_SUBVERSION=" + api_subversion
$ WC "alignbytes='" + alignbytes + "'"
$ WC "aphostname='" + "'"
$ WC "ar='" + "'"
End of Patch.
Peter Prymmer
