On 17/01/06, Craig Berry <[EMAIL PROTECTED]> wrote:
>
> On Tuesday, January 17, 2006, at 03:26AM, Allison Randal <[EMAIL PROTECTED]>
> wrote:
>
> >On Dec 27, 2005, at 18:59, Craig A. Berry wrote:
> >
>
> >This patch has a few problems that show up as a large number of
> >"uninitialized value" warnings during 'make test'. The first problem
> >is that it assumes there will always be a captured value, even from
> >an optional atom:
> >
> >> + if( m/(\w+::)?(\w+)/) {
> >> + # substitute case-preserved version of name
> >> + my $podname = $2;
> >> + my $prefix = $1;
> >
> >I fixed this one by just changing that last line to:
> >
> >my $prefix = $1 || '';
>
> Clearly the right thing to do. I'm surprised the uninitialized value
> warnings have not caused smoke in the last few weeks that my change has been
> in blead.
>
Unless $1 can legitimately be "0", surely?
S.
