Craig A. Berry wrote:
At 7:46 AM -0500 1/18/06, John E. Malmberg wrote:

ext/Digest/SHA/t/2-nist-sha-oo - not investigated yet.

Now:
EXT/DIGEST/SHA/T/2-NIST-SHA-OO....ok

ext/Digest/SHA/t/6-dump-load - bug found.
Merging VMS path with UNIX path with string concatenation.
#26899 may fix that, although I haven't tried it yet.

No it does not seem to:
$ MCR Sys$Disk:[]Perl. "-I[-.lib]" "[-.EXT.DIGEST.SHA.T]6-DUMP-LOAD.T"
1..4
# Running under perl version 5.009003 for VMS
# Current time local: Wed Jan 18 20:18:47 2006
# Current time GMT:   Thu Jan 19 01:18:47 2006
# Using Test.pm version 1.25
[end of test output]

$ MCR Sys$Disk:[]Perl. "-I[-.lib]" ../ext/Digest/SHA/t/6-dump-load.t
1..4
# Running under perl version 5.009003 for VMS
# Current time local: Wed Jan 18 20:18:31 2006
# Current time GMT:   Thu Jan 19 01:18:31 2006
# Using Test.pm version 1.25
ok 1
ok 2
ok 3
ok 4

main::([-.EXT.DIGEST.SHA.T]6-DUMP-LOAD.T:46):
46:                 $filename = dirname($0) . "/state/state.$ext[$i]";
  DB<4> n
  DB<4> x $filename
0  '[-.EXT.DIGEST.SHA.T]/state/state.1'

Looks like another bug lurking there.

lib/File/Compare - if I investigated this before, I forgot what the results 
were.

Now I remember, the flush code in Perl is missing an fsync() call, so that setting that option on files will not work reliably, especially on OpenVMS. A test is needed for that.

Now:
EAGLE> MCR Sys$Disk:[]Perl. "-T" "-I[-.lib]" [-.lib.file]compare.t
1..13
ok 1
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
ok 8
ok 9
ok 10
ok 11 # fh/file [0]
ok 12 # file/file [0]
ok 13 #  file/fileCR [0]


p_tainted.t works if fed a UNIX path name for the test.

$ MCR Sys$Disk:[]Perl. "-T" "-I[-.lib]" ../ext/list/util/t/p_tainted.t
1..4
ok 1 - constant number
ok 2 - known variable
ok 3 - environment variable
ok 4 - copy of environment variable

-John
[EMAIL PROTECTED]
Personal Opinion Only

Reply via email to