Looks great, I'll commit it. Thanks for your work. -Ken On Sat, Jun 14, 2008 at 11:26 PM, Craig A. Berry <[EMAIL PROTECTED]> wrote:
> At 2:03 AM -0500 5/30/08, Ken Williams wrote: > >On Thu, May 29, 2008 at 10:13 PM, Craig A. Berry > ><[EMAIL PROTECTED]> wrote: > > > >> I think it's important that we not apply any more > >> patches for M::B to blead until we get things synched up -- the merge > >> will just get worse if we put it off. > > > >I would prefer to not apply any more M::B patches to blead unless > >they're integrating from the canonical M::B code. > > I think that's the plan. > > > Sometimes the > >bleadkeepers are more responsive than I am, though, so that's likely > >why patches are routed there first sometimes... > > Or sometimes people have an itch to scratch that spans module > boundaries or don't know or don't remember to put changes in the > module's RT queue first. > > The only two changes to Module::Build in blead since the beginning of 2008 > are: > > http://public.activestate.com/cgi-bin/perlbrowse/p/33332 > > http://public.activestate.com/cgi-bin/perlbrowse/p/33340 > > The first one is already in M::B trunk and the second may not be > applicable any more (not sure). > > I've now at long last put my revision of John's patch in the RT queue here: > > http://rt.cpan.org/Ticket/Display.html?id=36762 > > The primary change from what he submitted was to make it against M::B > trunk instead of blead. The other thing was that it didn't seem to > me we should need to know in Base.pm or Build.pm which make utility > is in use since that should only be relevant if running in > compatibility mode, so I moved those bits to Compat.pm. > > > -- > ________________________________________ > Craig A. Berry > mailto:[EMAIL PROTECTED] > > "... getting out of a sonnet is much more > difficult than getting in." > Brad Leithauser >
