Constantin and Mac,
Const Kaplinsky wrote:
>
> >>>>> "MR" == Mac Reiter <[EMAIL PROTECTED]> writes:
>
> MR> Just as a note from someone who has been working to port the
> MR> VNCviewer code to new platforms:
>
> MR> The use of "log" as a global variable name was and is
> MR> amazingly poorly thought out. "log()" is a standard math
Considering how much of VNC is amazingly well thought out, I'm
glad the global log variable name is where the lack of foresight
did occur. Frankly, changing a global variable name is nothing
compared to the challenge of designing and implementing a usable,
cross-platform remote display system.
> MR> library function, and many compilers (the ones I keep having
> MR> to use, in particular) are not happy about trying to access a
> MR> member method of a function pointer... In my set of code, I
> MR> have replaced all instances of "log" with "globallog", but
> MR> almost any name would be better than "log". Even "Log" would
> MR> work (though I personally hate using only capitalization to
> MR> distinguish things), except that the class is named "Log".
>
> You're right, log is a bad choice for a global variable. I'm faced
> with the same problem trying to port the source to Borland C++. Maybe
> it would be a good idea to pick a good name for this variable and to
> use it in all VNC flavours, so I've changed the name to "vnclog" in my
> sources and I hope this name will be acceptable for developers of
> official VNC. Also, I'm planning to send a bunch of my TightVNC
> changes to Tridia and I hope this name change as a part of patch will
> be included into the TridiaVNC codebase.
We have no problem updating the "log" global variable name to
"vnclog". Please do include this in the patch set for the Tight
updates (1.1p9/1.2).
>
> MR> I am cross posting because this exists in both the AT&T and
> MR> the Tridia sources.
>
> MR> Mac
>
> --
> With Best Wishes,
> Constantin
>
> -----------------------------------------
> TridiaVNC - http://www.tridiavnc.com/
--
Brian
----------------------------------------------------------------------------
TridiaVNC, the cross-platform, open source, remote control solution.
http://www.TridiaVNC.com/ and http://www.developVNC.org/
Java VNC Server Demo:
http://www.developVNC.org/logged-in/jVNC-info.html
---------------------------------------------------------------------
To unsubscribe, send a message with the line: unsubscribe vnc-list
to [EMAIL PROTECTED]
See also: http://www.uk.research.att.com/vnc/intouch.html
---------------------------------------------------------------------
