Thanks for the contribution! Yep, I posted some comments.
In short: I think it needs some more work. One additional comment that I forgot to mention in the review: I would really love to see unittests... --a > On 11 Sep 2017, at 17:53, Ed Warnicke <hagb...@gmail.com> wrote: > > Andrew, > Could you have a look? > > Ed > >> On Mon, Sep 11, 2017 at 2:37 AM, chore <s3m2e1.6s...@gmail.com> wrote: >> Dear Team >> >> I had a commit in acl plugin to support Icmp proto in Stateful ACL. please >> kindly review the changes. >> >> Best Regards, >> Chore >> >> _______________________________________________ >> vpp-dev mailing list >> vpp-dev@lists.fd.io >> https://lists.fd.io/mailman/listinfo/vpp-dev > > _______________________________________________ > vpp-dev mailing list > vpp-dev@lists.fd.io > https://lists.fd.io/mailman/listinfo/vpp-dev
_______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
