Eeh, we haven't previously advertised support for VLAN tags on af_packet 
before; I could believe it was a missing feature, but I have a harder time 
accepting it was a bug.

I'm not strongly against the merge (though I do have a preference for strongly 
encouraging people to keep up with releases at this time), but I do want us to 
be clear about the disposition of this change.

Chris.

> -----Original Message-----
> From: [email protected] [mailto:[email protected]] On
> Behalf Of [email protected]
> Sent: Friday, September 29, 2017 11:43
> To: Neale Ranns (nranns) <[email protected]>
> Cc: [email protected]
> Subject: Re: [vpp-dev] vlan sub interfaces
> 
> well looking at the change it definitely suggests to be a bug fix.
> 
> we are currently using 1707 builds, and dont have plan to move to newer
> release right now, so would prefer a merge to 1707.
> 
> Regards,
> Prabhjot
> 
> Quoting "Neale Ranns (nranns)"
> <[email protected]>:
> 
> > With my release manager hat on …
> > Do we consider support for VLAN tags on an AF packet interface a bug
> > fix (to be back ported) or a new feature (available from 17.10
> > onwards)?
> >
> > /neale
> >
> > -----Original Message-----
> > From: "[email protected]" <[email protected]>
> > Date: Thursday, 28 September 2017 at 13:07
> > To: "Dave Barach (dbarach)" <[email protected]>
> > Cc: "Neale Ranns (nranns)" <[email protected]>, "John Lo (loj)"
> > <[email protected]>, "[email protected]" <[email protected]>, Akshaya
> > Nadahalli <[email protected]>
> > Subject: Re: [vpp-dev] vlan sub interfaces
> >
> >     yes i verified it on stable/1707 itself.
> >
> >     Regards,
> >     Prabhjot
> >
> >     Quoting "Dave Barach (dbarach)" <[email protected]>:
> >
> >     > See https://gerrit.fd.io/r/#/c/8590. The patch cherry-picked easily
> >     > to stable/1707.
> >     >
> >     > Assuming that the cherry-pick patch validates - and that it solves
> >     > your problem - it will be up to Neale [as the 17.07 release manager]
> >     > whether to merge it or not.
> >     >
> >     > Please let us know whether the cherry-pick patch works for you.
> >     >
> >     > Thanks… Dave
> >     >
> >     > From: [email protected]
> >     > [mailto:[email protected]] On Behalf Of Prabhjot Singh Sethi
> >     > Sent: Thursday, September 28, 2017 3:27 PM
> >     > To: Akshaya Nadahalli <[email protected]>; Prabhjot Singh Sethi
> >     > <[email protected]>; [email protected]; John Lo (loj)
> >     > <[email protected]>
> >     > Subject: Re: [vpp-dev] vlan sub interfaces
> >     >
> >     > yes it works perfectly fine with this patch.
> >     > i hope this will be pushed to 17.07 branch as well.
> >     >
> >     > Thanks for the help :)
> >     >
> >     > Regards,
> >     > Prabhjot
> >     >
> >     > ----- Original Message -----
> >     > From:
> >     > "Akshaya Nadahalli"
> <[email protected]<mailto:[email protected]>>
> >     >
> >     > To:
> >     > "Prabhjot Singh Sethi"
> >     > <[email protected]<mailto:[email protected]>>,
> >     > <[email protected]<mailto:[email protected]>>, "John Lo"
> >     > <[email protected]<mailto:[email protected]>>
> >     > Cc:
> >     >
> >     > Sent:
> >     > Thu, 28 Sep 2017 19:18:50 +0530
> >     > Subject:
> >     > Re: [vpp-dev] vlan sub interfaces
> >     >
> >     >
> >     > Hi Prabhjot,
> >     >
> >     >
> >     >
> >     > Can you pls try with below patch and see if it helps:
> >     >
> >     > https://gerrit.fd.io/r/#/c/8435/
> >     >
> >     >
> >     >
> >     > Regards,
> >     >
> >     > Akshaya N
> >     >
> >     > On Thursday 28 September 2017 03:45 PM, Prabhjot Singh Sethi wrote:
> >     > trying again with more appropriate subject
> >     >
> >     > Can some one please help if i am missing any thing over here ?
> >     >
> >     > As mentioned earlier, i have interface host-eth10 and sub interface
> >     > host-eth10.10 (create sub host-eth10 10)
> >     > host-eth10 is associated to bridge domain 2 and sub interface is
> >     > associated to bridge domain 3
> >     > when VPP receives tagged packet with vlan 10 it still associates it
> >     > to bd 2 and not bd 3
> >     >
> >     > Note: if i don't associate any bd with base interface it just drops
> >     > the packet with some error.
> >     >
> >     > Regards,
> >     > Prabhjot
> >     >
> >     >
> >     > _______________________________________________
> >     > vpp-dev mailing list
> >     > [email protected]<mailto:[email protected]>
> >     > https://lists.fd.io/mailman/listinfo/vpp-dev
> >     >
> >     > --
> >     > Regards,
> >     > Akshaya N
> 
> 
> _______________________________________________
> vpp-dev mailing list
> [email protected]
> https://lists.fd.io/mailman/listinfo/vpp-dev
_______________________________________________
vpp-dev mailing list
[email protected]
https://lists.fd.io/mailman/listinfo/vpp-dev

Reply via email to