Hi Jon, > On 10 Nov 2017, at 23:11, Jon Loeliger <[email protected]> wrote: > > Folks, > > Every error from the ACL implementation is -1. Generically bad. > Without regard for what might be more useful to an upper-layer UI.
When we discussed with the openstack folks the way they are treating errors was all as catastrophic, but yes more distinction would be better, so thanks a lot for taking care of it! > > So I submitted a patch to help this situation some. > https://gerrit.fd.io/r/#/c/9383/ > > I have built and tested it locally, but it fails the Verify Tests because > it has a test that is expecting a hard-coded -1 return from some tests. > Returning a -6 wasn't good enough. > > First, this is draconian for no really good reason. Second, it should be > fixed. Third, I would do that except I am stupid and need a clue where > or how to fix this situation so the tests are less draconian. (Can we > get a "less than 0" test instead of "equal to -1"?) Yeah. So we would need to first submit new test(s) that pass on both current and new code and then the new code itself... wanna take a shot at it or should I ? > > Oh, and, it's pretty clear why the Verify failed, despite the Jenkins job > saying it was unable to determine a cause. Um, double blerg. Alas, this one I leave to someone else to comment on :) —a > > Any help for the weary here? > > Thanks, > jdl > > > 21:21:43 ERROR: ACL create/delete test > 21:21:43 > ------------------------------------------------------------------------------ > 21:21:43 Traceback (most recent call last): > 21:21:43 File > "/w/workspace/vpp-verify-master-ubuntu1604/test/test_acl_plugin.py", line > 563, in test_0001_acl_create > 21:21:43 tag="FFFF:FFFF", expected_retval=-1) > 21:21:43 File > "/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line > 2483, in acl_add_replace > 21:21:43 expected_retval=expected_retval) > 21:21:43 File > "/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line > 167, in api > 21:21:43 raise UnexpectedApiReturnValueError(msg) > 21:21:43 UnexpectedApiReturnValueError: API call failed, expected -1 return > value instead of -6 in acl_add_replace_reply(_0=936, context=33, > acl_index=432, retval=-6) > 21:21:43 > _______________________________________________ > vpp-dev mailing list > [email protected] > https://lists.fd.io/mailman/listinfo/vpp-dev
_______________________________________________ vpp-dev mailing list [email protected] https://lists.fd.io/mailman/listinfo/vpp-dev
