Dear Gabriel,
The files mentioned below fall into several buckets:
* Code samples which might reasonably move to .../extras
* Things we’re not using at the moment, but which would take someone a good
long time to build from scratch.
* The simulated annealing driver in vppinfra/anneal.c is a good example.
* Debris which should be removed
I’ll push a change-set to remove debris. Most of it is mine anyhow... (😉)...
Thanks… Dave
From: [email protected] [mailto:[email protected]] On
Behalf Of Gabriel Ganne
Sent: Tuesday, December 5, 2017 9:52 AM
To: [email protected]
Subject: [vpp-dev] some files are never compiled
Hi,
Following a question by Kevin Wang in
VPP-1066<https://jira.fd.io/browse/VPP-1066>, I saw that some files are
actually never compiled.
Could some external plugin be using them ?
Can (Should) they be removed ?
As an example, I followed the smp.c, and smp_fido.[ch] files.
They have been disabled by commit 01d86c7f6f05938c7d3fe181bd0aa2f75ccdd1df
(reviewed here: https://gerrit.fd.io/r/#/c/2273/) almost 1.5 year ago.
Here is how I listed them :
for file in $(git find "\.c$"); do
f=`basename $file .c` ;
git grep -q "$f\.c";
if [ $? -eq 1 ] ; then echo $file ; fi ;
done
src/examples/vlib/plex_test.c
src/tools/g2/mkversion.c
src/vlib/elog_samples.c
src/vlib/parse.c
src/vlib/parse_builtin.c
src/vnet/ethernet/mac_swap.c
src/vnet/fib/fib_entry_src_default.c
src/vnet/ip/ip4_test.c
src/vnet/map/examples/health_check.c
src/vpp/app/sticky_hash.c
src/vppinfra/anneal.c
src/vppinfra/mod_test_hash.c
src/vppinfra/pfhash.c
src/vppinfra/phash.c
src/vppinfra/qhash.c
src/vppinfra/smp.c
src/vppinfra/smp_fifo.c
src/vppinfra/test_pfhash.c
src/vppinfra/test_phash.c
src/vppinfra/test_pool.c
src/vppinfra/test_qhash.c
src/vppinfra/tw_timer_4t_3w_4sl_ov.c
src/vppinfra/unix-kelog.c
--
Gabriel Ganne
_______________________________________________
vpp-dev mailing list
[email protected]
https://lists.fd.io/mailman/listinfo/vpp-dev
