Hi Tom, this is caused by simple fact that verify job runs only for a subset of supported distros. At (development) time of the patch, I wasn't aware of this, and the result is that after the commit containing VAPI tests, some centos people started to complain that it doesn't build for them or whatever. I made it work via the subsequent patch.
I *think* that centos doesn't list subunit as dependency for check (via yum I think), but it is, in fact a dependency. Feel free to drop it, but you'll need to either disable building of VAPI tests (C++ tests are already disabled because dumb C++ version on centos - see test/ext/Makefile), rework the unit tests to use a different framework or come up with some other kind of solution... Regards, Klement > -----Original Message----- > From: Thomas F Herbert [mailto:therb...@redhat.com] > Sent: Monday, March 5, 2018 6:06 PM > To: Gabriel Ganne <gabriel.ga...@enea.com> > Cc: Billy McFall <bmcf...@redhat.com>; Klement Sekera -X (ksekera - > PANTHEON TECHNOLOGIES at Cisco) <ksek...@cisco.com>; Marco Varlese > <marco.varl...@suse.com>; vpp-dev <vpp-dev@lists.fd.io> > Subject: subunit requirement > > Garbriel and all, > > I am working on the release packaging for 18.01.1 for Centos. > > > I want to discuss the subunit requirement in deps and in the spec file > originally > introduced in this patch. > > > https://gerrit.fd.io/r/gitweb?p=vpp.git;a=commitdiff;h=d3e671e0dbb879d90 > f00bdee608ee0bb5f6357ae > > Although subunit is in Fedora (and EPEL), it is not available in Centos so the > subunit requirement breaks release builds for Centos. > > The following patch was merged in October and cherry-picked into 1710 > which made this requirement Fedora only. > > e41289115ffb24d95a5d0bc2ef33001d06a28688 > > Subsequently in this commit > > > b8bbd6521fbab6579e4c571f61489f995f56bc78, it was made a requirement > for Centos as well. > > > I want to propose an upstream patch to remove the subunit requirement for > Centos but I should check with everyone as to the implications. > > > --Tom > > > -- > Thomas F Herbert > NFV and Fast Data Planes > Networking Group Office of the CTO > Red Hat -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#8483): https://lists.fd.io/g/vpp-dev/message/8483 View All Messages In Topic (3): https://lists.fd.io/g/vpp-dev/topic/13886253 Mute This Topic: https://lists.fd.io/mt/13886253/21656 New Topic: https://lists.fd.io/g/vpp-dev/post Change Your Subscription: https://lists.fd.io/g/vpp-dev/editsub/21656 Group Home: https://lists.fd.io/g/vpp-dev Contact Group Owner: vpp-dev+ow...@lists.fd.io Terms of Service: https://lists.fd.io/static/tos Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub -=-=-=-=-=-=-=-=-=-=-=-
